You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey 馃檪 Thank you very much for providing this useful library! I noticed some unintuitive behaviour in the code_to_flag function, when supplying a country code in lowercase:
I guess this happens because code_to_flag, unlike most other functions, doesn't use .to_uppercase() to normalize the input.
Expected behaviour
I'd either expect all methods to return None for lowercase codes, or the code_to_flag function to return the correct flag even when supplying a lowercase country code.
I'm happy to work on a fix for the problem if you don't have the time, but I'd need to know which behaviour you'd prefer.
The text was updated successfully, but these errors were encountered:
Hey 馃檪 Thank you very much for providing this useful library! I noticed some unintuitive behaviour in the
code_to_flag
function, when supplying a country code in lowercase:I guess this happens because
code_to_flag
, unlike most other functions, doesn't use.to_uppercase()
to normalize the input.Expected behaviour
I'd either expect all methods to return
None
for lowercase codes, or thecode_to_flag
function to return the correct flag even when supplying a lowercase country code.I'm happy to work on a fix for the problem if you don't have the time, but I'd need to know which behaviour you'd prefer.
The text was updated successfully, but these errors were encountered: