Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts): argument --yes in yum install is unrecognized #196

Merged
merged 1 commit into from Sep 6, 2022

Conversation

Hkmu
Copy link
Contributor

@Hkmu Hkmu commented Sep 6, 2022

--yes is not a valid argument but -y. Replacing --yes with -y or using yes CLI can resolve this.

Resolves: /issues/195#issue-1363352738

What changes this PR introduce?

Removed --yes argument from scripts/dependencies/install_yum_packages.sh and used yes command instead.

List any relevant issue numbers

#195

Is there anything you'd like reviewers to focus on?

No.

`--yes` is not a valid argument but `-y`. Replacing `--yes` with `-y` or using `yes` CLI can resolve this.

Resolves: leon-ai/issues/195#issue-1363352738
Copy link
Member

@theoludwig theoludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for your contribution.
Indeed, --yes doesn't exist for the yum CLI.
Read more about Leon usage and support for GNU Arch Linux here: #195 (comment)

@theoludwig theoludwig merged commit 8e57d99 into leon-ai:develop Sep 6, 2022
@Hkmu Hkmu deleted the fix-yum-install branch September 7, 2022 02:17
@github-actions
Copy link

🎉 This PR is included in version 1.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] leon create birth failed (uncognized option --yes for yum package manager)
2 participants