Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prefersHomeIndicatorAutoHidden not called #566

Closed
mmdumi opened this issue Feb 22, 2024 · 2 comments
Closed

prefersHomeIndicatorAutoHidden not called #566

mmdumi opened this issue Feb 22, 2024 · 2 comments
Labels
enhancement

Comments

@mmdumi
Copy link

mmdumi commented Feb 22, 2024

Describe the Bug
I'm trying to control the home indicator appearance when presenting a controller from inside LNPopupController framework.

To Reproduce
I've attached a sample project to easily test this behaviour.

  1. In ViewController line: 31 - if you call presentPopupBar you will see that prefersHomeIndicatorAutoHidden inside PresentedViewController is NOT called
  2. In ViewController line: 32 - if you call present(controller you will see that prefersHomeIndicatorAutoHidden inside PresentedViewController IS called correctly

Additional Context
Uploaded sample project.
Test.zip

Thank you
@mmdumi mmdumi added the bug label Feb 22, 2024
@LeoNatan
Copy link
Owner

Hello,

Indeed, this is a use case I have not looked into. Will try to provide it soon.

Thanks

@LeoNatan LeoNatan added enhancement and removed bug labels Feb 22, 2024
LeoNatan added a commit that referenced this issue Feb 22, 2024
@LeoNatan
Add support for prefersHomeIndicatorAutoHidden/setNeedsUpdateOfHomeIn…
a684ed3 
…dicatorAutoHidden

Implements #566
@LeoNatan
Copy link
Owner

2.18.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mmdumi @LeoNatan