Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

How to avoid whole app crashing because of assert https http #13

Closed
vitovalov opened this issue Feb 10, 2018 · 2 comments
Closed

How to avoid whole app crashing because of assert https http #13

vitovalov opened this issue Feb 10, 2018 · 2 comments

Comments

@vitovalov
Copy link

I have a large list of urls that I need to preview their favicon.
While scrolling the list some of them are like angel.co, with no http, https.
Some contain www.google.com. Some are forum.site.com

While compiling in debug, the assert in Download.swift gets hit every time some non http urls comes in.
Even if I do "if !contain http -> insert http", still having this issue.

For instance this one "http://forum.tvfreeload.com/ucp.php" causes the trouble.

Console:

po urls
▿ 1 element
  ▿ 0 : data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAMAAAAoLQ9TAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAy ... rkJggg==
    - _url : data:image/png;base64,iVBO

Maybe you could externalise somehow the final url that needs to be downloaded so we could use our image caching libs, for example, to get and cache the final image?

@leonbreedt
Copy link
Owner

Interesting, didn't know it was possible to define icons inline like that. Fixed in 3.0.2.

@vitovalov
Copy link
Author

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants