Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bloom keys not synced to target redis instance #60

Open
Prudhvi0717 opened this issue Jun 22, 2023 · 1 comment
Open

Bloom keys not synced to target redis instance #60

Prudhvi0717 opened this issue Jun 22, 2023 · 1 comment

Comments

@Prudhvi0717
Copy link

Prudhvi0717 commented Jun 22, 2023

When Syncing redis instances with "rst" the data and bloom filters and its keys in initial snapshot are being migrated to target instance. But during further sync the new created bloom keys are not being synced. The normal keys are synced seamlessly.

So can we also have the bloom keys be synced? Is there anyway to do this? @leonchen83

@Prudhvi0717 Prudhvi0717 changed the title BloomFilters not synced to target redis instance Bloom keys not synced to target redis instance Jun 22, 2023
@leonchen83
Copy link
Owner

Hi @Prudhvi0717
Unfortunately yes, redis-rdb-cli does not support third party modules like redisbloom, rejson and etc.
Because there are too many third party modules. so implement module sync is very hard(we should parse every module command and sync these commands to target)

If you want to sync bloom filter. You should fork this project and modify following java class to support above modules

XRst.java
SingleRdbVisitor.java in ext/rst package
ClusterRdbVisitor.java in ext/rst package

step1: in XRst.java
write your own bloom filter command parser and register parsers to replicator like following

// since redis 7.0
replicator.addCommandParser(CommandName.name("SPUBLISH"), new CombineCommandParser(new SPublishParser()));
replicator.addCommandParser(CommandName.name("FUNCTION"), new CombineCommandParser(new FunctionParser()));

step2: in SingleRdbVisitor and ClusterRdbVisitor
handle bloom filter command and synced to target redis instance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants