Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate data classes from object model #23

Closed
leonhard-s opened this issue Sep 13, 2020 · 2 comments
Closed

Separate data classes from object model #23

leonhard-s opened this issue Sep 13, 2020 · 2 comments
Assignees
Labels
discussion Additional opinions wanted prio:normal No immediate action required

Comments

@leonhard-s
Copy link
Owner

Currently, the "active" classes (e.g. Character, Outfit) are tightly associated with their respective data class (CharacterData and OutfitData respectively).

This seemed like a promising idea initially, but it is already starting to break down with relational data types, which will only worsen as generic sub-query interfaces (#15) or reports (#18) are implemented. There simply are many types of server responses that do not match a collection.

It seems like moving all of these data classes into a separate models module would be a good solution to underline this difference, and it would greatly declutter some of the wordier modules like ps2.fire as well.

@leonhard-s leonhard-s added the discussion Additional opinions wanted label Sep 13, 2020
@leonhard-s
Copy link
Owner Author

A tentative version of the split has been added as of 065a0e9 of the models branch.

This change has led to several tiny modules (i.e. ones with only one or two classes in them), these will be consolidated in an upcoming commit.

@leonhard-s leonhard-s added the prio:normal No immediate action required label Sep 19, 2020
@leonhard-s leonhard-s self-assigned this Sep 19, 2020
@leonhard-s
Copy link
Owner Author

The commit mentioned above has just been finalised and pushed to models. Remaining work is tied into other issues and tests (#24), closing this issue as its primary goal was met.

@leonhard-s leonhard-s added this to the Version 0.1 Beta milestone Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Additional opinions wanted prio:normal No immediate action required
Projects
None yet
Development

No branches or pull requests

1 participant