You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the "active" classes (e.g. Character, Outfit) are tightly associated with their respective data class (CharacterData and OutfitData respectively).
This seemed like a promising idea initially, but it is already starting to break down with relational data types, which will only worsen as generic sub-query interfaces (#15) or reports (#18) are implemented. There simply are many types of server responses that do not match a collection.
It seems like moving all of these data classes into a separate models module would be a good solution to underline this difference, and it would greatly declutter some of the wordier modules like ps2.fire as well.
The text was updated successfully, but these errors were encountered:
The commit mentioned above has just been finalised and pushed to models. Remaining work is tied into other issues and tests (#24), closing this issue as its primary goal was met.
Currently, the "active" classes (e.g.
Character
,Outfit
) are tightly associated with their respective data class (CharacterData
andOutfitData
respectively).This seemed like a promising idea initially, but it is already starting to break down with relational data types, which will only worsen as generic sub-query interfaces (#15) or reports (#18) are implemented. There simply are many types of server responses that do not match a collection.
It seems like moving all of these data classes into a separate
models
module would be a good solution to underline this difference, and it would greatly declutter some of the wordier modules likeps2.fire
as well.The text was updated successfully, but these errors were encountered: