Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please pin the sax dependency #68

Closed
defunctzombie opened this issue Feb 13, 2013 · 2 comments
Closed

please pin the sax dependency #68

defunctzombie opened this issue Feb 13, 2013 · 2 comments

Comments

@defunctzombie
Copy link

https://github.com/Leonidas-from-XIV/node-xml2js/blob/master/package.json#L36

If sax ever updates in a breaking way, future installs of versions of this module will break for your users. The best approach is to pin the exact version which you have tested with and published with. If in the future you wish to investigate issues with a version, not knowing what version of sax was being used will make very difficult.

Leonidas-from-XIV added a commit that referenced this issue Feb 14, 2013
@Leonidas-from-XIV
Copy link
Owner

I didn't think of that, but I see your point, so I'm pinning it at a version that I tested it with.

@defunctzombie
Copy link
Author

Thank you for caring :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants