Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring the index.js file of AWS and GCP plugin by renaming the parameter #156

Open
Shofiya2003 opened this issue Mar 11, 2023 · 1 comment

Comments

@Shofiya2003
Copy link

We are passing in the configuration details to the plugin from the ncConfig file via the common package

providersToLoad[provider.tag] = module(provider.configPath);

here the parameter for taking the configuration details from the ncConfig file is named options.

const ncAwsPlugin = options => {

Similarly, the GCP plugin is also taking in the configuration details as a parameter named options.

const ncGcpPlugin = options => {

It would be easy to understand if we rename the options as configuration details

@Shofiya2003
Copy link
Author

@mbcse @rajitha1998
Can we do something like this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant