Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support messageformat v3 #74

Closed
eshkard opened this issue Aug 3, 2021 · 4 comments · Fixed by #83
Closed

Support messageformat v3 #74

eshkard opened this issue Aug 3, 2021 · 4 comments · Fixed by #83

Comments

@eshkard
Copy link

eshkard commented Aug 3, 2021

Hi npm shows warning on "messageformat" package renamed as @messageformat/core.
Will you address this dependency issue?

"warning messageformat@2.3.0: Package renamed as '@messageformat/core', see messageformat.github.io for more details. 'messageformat' will eventually provide a polyfill for Intl.MessageFormat, once it's been defined by Unicode & ECMA."

Thank's,
Evgeny

@lephyrus lephyrus changed the title "messageformat" dependency package renamed Support messageformat v3 Nov 27, 2021
@lephyrus
Copy link
Owner

It's not just a renamed package - the new version has a number of breaking changes. I have to adapt a few things, shouldn't be hard.

@lephyrus
Copy link
Owner

Turns out the changes in messageformat v3 are anything but trivial for the way we use it, as a compiler at runtime. Don't expect this library to support v3 anytime soon, sorry.

@tuuling
Copy link

tuuling commented Sep 26, 2022

Turns out the changes in messageformat v3 are anything but trivial for the way we use it, as a compiler at runtime. Don't expect this library to support v3 anytime soon, sorry.

If someone were to provide a PR that supports v3, would you consider making a new major release with messageformat 3 support?

@lephyrus
Copy link
Owner

Sorry that support for messageformat v3 is still missing. It's actually pretty much done here: #83. I need to go back and make sure I really understand what behaves differently so there are no bad surprises. I should be able to do it in the coming days.

This was referenced Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants