Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Is this meant to be a Vue.js Composable or helper? #5

Closed
bitfactory-oussama-fadlaoui opened this issue Mar 9, 2023 · 2 comments

Comments

@bitfactory-oussama-fadlaoui
Copy link
Contributor

The way I see it, Vue.js composables will hook into components and/or other composables using Vue.js objects.

This package seems to use the naming convention of a composable, yet is not in fact a composable as it doesn't do any of the above mentioned things. I would like to contribute to update the package to be a composable if this is a wish of @lepikhinb.

@ricardov03
Copy link

Go ahead, and made the suggestion. I know @lepikhinb it's open to good ideas. I want to include support to others custom paginators. For example, I'm using this library to create my paginator: PrimeVue Paginator I'm missing one parameter (Per Page) from this library, but could be nice if you can create plugins to feed any custom paginator.

@lepikhinb
Copy link
Owner

@bitfactory-oussama-fadlaoui thanks for the feedback.

VueUse (an officially supported library) provides a ton of utilities that follow the same naming convention yet have nothing to do with Vue.js objects (see: https://vueuse.org/core/useNow/).

usePaginator returns an objects you'd usually love to decompose, so this kinda makes sense.

I would prefer keeping everything as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants