Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Aspect Fill #1

Closed
LePips opened this issue Sep 19, 2022 · 1 comment
Closed

Better Aspect Fill #1

LePips opened this issue Sep 19, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@LePips
Copy link
Owner

LePips commented Sep 19, 2022

Currently, VLCVideoPlayer.Event.aspectFill animation is manually controlled.

Replace to be more customizable by removing the manual animation and replace with:

enum Event {
    /// Aspect fill given the percentage between 0...1.0
    case aspectFill(Float)
}

This would set the aspect fill state to a certain progress. This would allow gestures to set the aspect fill based on its percentage completed and the send event can be surrounded by an animation for animations.

@LePips LePips added the enhancement New feature or request label Sep 19, 2022
@LePips LePips changed the title Event - Better Aspect Fill Better Aspect Fill Sep 19, 2022
@LePips
Copy link
Owner Author

LePips commented Sep 20, 2022

71fcc74

@LePips LePips closed this as completed Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant