Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Site_Type" and "Index_Region" to "Index_Class" #83

Open
leppott opened this issue Nov 15, 2022 · 2 comments
Open

Change "Site_Type" and "Index_Region" to "Index_Class" #83

leppott opened this issue Nov 15, 2022 · 2 comments

Comments

@leppott
Copy link
Owner

leppott commented Nov 15, 2022

Is your feature request related to a problem? Please describe.
Have used Site_Type and Index_Region in multiple places between BioMonTools and BCGcalc packages.

Change to "Index_Class"

Describe the solution you'd like
Will need to deprecate the input parameter in files.

Describe alternatives you've considered
Need consistency between packages.

Additional context
Will have to change:

  • functions (input parameters)
  • examples
  • example files.
  • vignettes
  • other?
@leppott
Copy link
Owner Author

leppott commented Nov 15, 2022

  • ext\DataBenthos.xlsx
  • ext\MetricFlags.xlsx
  • ext\MetricScoring.xlsx
  • qc_checks.R
  • metric_values.R
  • metric_values_excel.R
  • metric_scores.R
  • data.R
  • data-raw\data_benthos_MBSS
  • data-raw\data_benthos_PacNW
  • data-raw\data_diatom_mmi_dev
  • data-raw\data_diatom_mmi_qc
  • data-raw\data_fish_MBSS
  • data-raw\metval_SCMB_IBI
  • data-raw\data_mmi_dev
  • vignette
  • Shiny,

@leppott
Copy link
Owner Author

leppott commented Nov 16, 2022

Calculation slower. Will need to fix.

Modified mutate, if_numeric, replace_na statement to use a data frame and not a tibble. The grouping was making it take minutes instead of < 2 seconds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant