Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty attribute value should be valid #104

Closed
noqsi opened this issue Mar 19, 2017 · 4 comments · Fixed by #845
Closed

Empty attribute value should be valid #104

noqsi opened this issue Mar 19, 2017 · 4 comments · Fixed by #845
Labels

Comments

@noqsi
Copy link
Contributor

noqsi commented Mar 19, 2017

Right now, attributes with empty values are not allowed. But an empty string is a perfectly valid string, and can be useful for back ends driving downstream flows for which blank input is valid.

@vzh
Copy link
Member

vzh commented Mar 21, 2017

I agree with this. Besides, such attributes could work as templates, e.g. in spice backends.

@graahnul-grom
Copy link
Member

@noqsi @vzh Although I agree with this, too, doing so right now will cause interoperability problems with geda-gaf. Schematics created in lepton
cannot be processed by that suite (gschem attributes with empty values
will be treated just like text, gnetlist will fail).
What about postponing the discussion and reopening the issue after
some major release?

@vzh
Copy link
Member

vzh commented Oct 25, 2018

Nothing will prevent users to create attributes in backward compatible manner.

@graahnul-grom
Copy link
Member

Yes, but one have to always keep it in mind while working on schematics.
Allowing an empty values for attributes seems to me as something akin to file format change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants