Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decoding really slow? #14

Closed
tinect opened this issue Oct 14, 2022 · 4 comments
Closed

Decoding really slow? #14

tinect opened this issue Oct 14, 2022 · 4 comments

Comments

@tinect
Copy link
Contributor

tinect commented Oct 14, 2022

device (laptop):
Ryzen 9 5950hx
RTX 3060

hash WtH3Bgx]WXxZWYkCu6f*ofWBR*j?IonhogNHRjj[ivxYRkR-oJbI
1280 x 528
decode: 320 ms 馃槺

hash WPRysgayxuj[xuoft7ayRjj[WBay~qj[M{ayofayM{fQxuayt7of
600 x 600
decode 150 ms

Is it really normal?

@leptoquark1
Copy link
Owner

No! Decoding should be much faster. Can you provide the images you used to benchmark?

I'll take a look on it.

@tinect
Copy link
Contributor Author

tinect commented Jan 22, 2023

hq_1280x1280
Attached is one of it. I don't know what the other one was, but I can reproduce the slowing decoding with any image on any device :-(

@leptoquark1
Copy link
Owner

This is the graph of the time to decode vs components X/Y option.

ShopwareHQ_1280x528_decode_chart

I will check if I can improve the performance...

@leptoquark1
Copy link
Owner

I've testet several implementations of decoding (incl. Wasm), but it looks like there is a bottleneck at the pow function, which is called exponential relative to component x/y setting and the resulting image dimensions.
As far as I can evaluate, it cannot be further improved (even though Bytecode is little better), but its all about the decoding processors clock rate :/

I will take a look into implementing the Wasm solution though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants