Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to syn-rsx 0.9 to allow things like on:my-event #57

Closed
gbj opened this issue Nov 7, 2022 · 1 comment
Closed

Update to syn-rsx 0.9 to allow things like on:my-event #57

gbj opened this issue Nov 7, 2022 · 1 comment

Comments

@gbj
Copy link
Collaborator

gbj commented Nov 7, 2022

Currently the syn-rsx crate doesn't allow mixing colons and dashes in attribute names, which breaks the on: syntax in custom event names, which are encouraged to have a dash like my-event.

I had a PR merged to syn-rsx that would allow this, but there are also some other breaking changes in their 0.9 release, so I'll need to make sure we're up to date.
@gbj gbj mentioned this issue Nov 12, 2022
Closed
@gbj
Copy link
Collaborator Author

gbj commented Nov 13, 2022

PR #75 should fix both this and issue #74.

@gbj gbj closed this as completed Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gbj