Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore behaviour in create_authorization_response call which previously accepted a OAuth2Request object as-is #558

Merged
merged 1 commit into from Jun 28, 2023

Conversation

TurnrDev
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No - rather, fixes one. Explaination here

  • You consent that the copyright of your pull request source code belongs to Authlib's author.

TurnrDev referenced this pull request Jun 27, 2023
- redesign OAuth2Request
- HttpRequest to JsonRequest
@lepture lepture merged commit e228702 into lepture:master Jun 28, 2023
8 checks passed
@lepture
Copy link
Owner

lepture commented Jun 28, 2023

Thanks

@TurnrDev
Copy link
Contributor Author

Amazing, I wasn't sure if this was going to be accepted or not!

Would you accept PRs that add support for more OIDC stuff? I unfortunately noticed this library doesn't supply any framework or even documentation on how to implement /.well-known/openid-configuration or JWKS endpoints.

@TurnrDev TurnrDev deleted the patch-1 branch June 28, 2023 07:56
@cas--
Copy link

cas-- commented Jul 22, 2023

Thanks @TurnrDev, this caught me out migrating old code based on Authlib 0.12 with custom create_oauth_request

Until this is released I am using a modified AuthorizationServer

from authlib.oauth2 import OAuth2Request
from authlib.integrations.flask_oauth2 import (
    AuthorizationServer as _AuthorizationServer,
)

class AuthorizationServer(_AuthorizationServer):
    def create_oauth2_request(self, request):
        if isinstance(request, OAuth2Request):
            return request

        return super().create_oauth2_request(request)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants