Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set JSONEncoder to json._default #536

Merged
merged 4 commits into from Jan 15, 2023
Merged

Set JSONEncoder to json._default #536

merged 4 commits into from Jan 15, 2023

Conversation

pythops
Copy link
Contributor

@pythops pythops commented Nov 5, 2022

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in docs/changes.rst summarizing the change and linking to the issue. Add .. versionchanged:: entries in any relevant code docs.

@pythops
Copy link
Contributor Author

pythops commented Dec 28, 2022

@azmeuk
can you please take a look at that one. this is blocking to use the latest version of Quart

@azmeuk
Copy link
Member

azmeuk commented Jan 13, 2023

It looks like JSONEncoder is not even used anymore. It was introduced with 6dea39d and was not called anymore with 92c6e39.
I think you can just remove the line.

@pythops
Copy link
Contributor Author

pythops commented Jan 15, 2023 •
edited

Even better !
Removed.

@azmeuk azmeuk merged commit 7138fc9 into wtforms:main Jan 15, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AttributeError: module 'quart.json' has no attribute 'JSONEncoder'
2 participants
@pythops @azmeuk