Minor improvements to the Quickstart document #104

Merged
merged 2 commits into from Jan 19, 2014

Projects

None yet

2 participants

@mlncn
Contributor
mlncn commented Dec 17, 2013

Most important is the change in the illustrative example for the route receiving the form submission from ('GET', 'POST') to ['GET', 'POST']— at least in Flask 0.10.1 the square bracket list notation is required.

@lepture
Owner
lepture commented Dec 18, 2013

at least in Flask 0.10.1 the square bracket list notation is required.

Are you sure? It actually supports both list and tuple. Coz tuple is faster, I put tuple here.

@mlncn
Contributor
mlncn commented Dec 19, 2013

Ah, you are right. I was sure i had tried it with ('GET', 'POST') but that does work for me— what i can reproduce is restricting it to just POST as ('POST') which of course does not work, gives 'Method not allowed'.

@lepture
Owner
lepture commented Dec 19, 2013

@mlncn ('POST') is not a tuple, ('POST',) is a tuple. Most people can make such a mistake.

@lepture
Owner
lepture commented Jan 19, 2014

@mlncn could you send me another clean patch?

If I cherry pick some of the commit, it will be fast forward. And I don't want to merge too many useless commits.

@mlncn
Contributor
mlncn commented Jan 19, 2014

Thank you! Cleaned up this patch-1 branch, https://github.com/mlncn/flask-wtf/tree/patch-1 — merge away!

@lepture lepture merged commit 32ab9b4 into lepture:master Jan 19, 2014

1 check passed

Details default The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment