Minor improvements to the Quickstart document #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Are you sure? It actually supports both list and tuple. Coz tuple is faster, I put tuple here. |
|
Ah, you are right. I was sure i had tried it with ('GET', 'POST') but that does work for me— what i can reproduce is restricting it to just POST as ('POST') which of course does not work, gives 'Method not allowed'. |
|
@mlncn |
|
@mlncn could you send me another clean patch? If I cherry pick some of the commit, it will be fast forward. And I don't want to merge too many useless commits. |
|
Thank you! Cleaned up this patch-1 branch, https://github.com/mlncn/flask-wtf/tree/patch-1 — merge away! |
lepture
added a commit
that referenced
this pull request
Jan 19, 2014
Minor improvements to the Quickstart document
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most important is the change in the illustrative example for the route receiving the form submission from ('GET', 'POST') to ['GET', 'POST']— at least in Flask 0.10.1 the square bracket list notation is required.