Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publish): deprecate publish --require-scripts #463

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

ghiscoding
Copy link
Member

Description

Deprecate lerna publish option --require-scripts

Motivation and Context

This option has been half deprecated for a long time in Lerna and even had a PR to remove it but it was never merged, so let's remove it for good in our next major version. (ref Lerna PR 1862)

How Has This Been Tested?

Types of changes

  • Chore (change that has absolutely no effect on users)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Merging #463 (6f9c969) into main (859ae03) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #463      +/-   ##
==========================================
+ Coverage   97.38%   97.38%   +0.01%     
==========================================
  Files         154      154              
  Lines        4534     4536       +2     
  Branches     1057     1058       +1     
==========================================
+ Hits         4415     4417       +2     
  Misses        119      119              
Impacted Files Coverage Δ
packages/publish/src/publish-command.ts 99.09% <ø> (ø)
...kages/cli/src/cli-commands/cli-publish-commands.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit e8ef54e into main Jan 27, 2023
@ghiscoding ghiscoding deleted the chore/deprecate-publish-require-scripts branch January 27, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant