Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(watch): add optional stdin key to exit watch mode cleanly #472

Merged
merged 2 commits into from
Feb 4, 2023

Conversation

ghiscoding
Copy link
Member

Description

a simple "Press x to exit watch mode"

Motivation and Context

add a simple keystroke watch to exit the watch mode cleanly

How Has This Been Tested?

Types of changes

  • Chore (change that has absolutely no effect on users)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Feb 4, 2023

Codecov Report

Merging #472 (61d8bfc) into main (5387b4e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 61d8bfc differs from pull request most recent head 6c23569. Consider uploading reports for the commit 6c23569 to get more accurate results

@@            Coverage Diff             @@
##             main     #472      +/-   ##
==========================================
+ Coverage   97.38%   97.39%   +0.01%     
==========================================
  Files         154      154              
  Lines        4536     4544       +8     
  Branches     1058     1060       +2     
==========================================
+ Hits         4417     4425       +8     
  Misses        119      119              
Impacted Files Coverage Δ
packages/watch/src/watch-command.ts 98.43% <100.00%> (+0.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit d0cf2d9 into main Feb 4, 2023
@ghiscoding ghiscoding deleted the feat/watch-exit branch February 4, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant