Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): TypeScript should be saved & published as LF, fixes #513 #514

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

ghiscoding
Copy link
Member

Description

TypeScript should be saved & published as LF line ending

Motivation and Context

  • Fixes Upgrade from 1.16.0 to 1.16.1 breaks run command #513, we should always save and publish CLI bin file as LF line ending since CRLF will cause problem with Yarn. This regression was introduced by the switch to TypeScript References and tsc -b executed from the project root which didn't have the proper line ending setting set in tsconfig root

How Has This Been Tested?

Ran a full build and validated that the line ending is really set to LF

Types of changes

  • Chore (change that has absolutely no effect on users)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ghiscoding ghiscoding merged commit 1c62eb7 into main Mar 13, 2023
@ghiscoding ghiscoding deleted the bugfix/tsc-build-with-newline-lf branch March 13, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade from 1.16.0 to 1.16.1 breaks run command
1 participant