Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(publish): add npm provenance to lerna publish #600

Merged
merged 1 commit into from
May 5, 2023

Conversation

ghiscoding
Copy link
Member

Description

As per Lerna PR 3674

This will provide access to npm provenance with GitHub Actions https://github.blog/2023-04-19-introducing-npm-package-provenance/

Motivation and Context

As per Lerna PR 3674, this follows Lerna implementation

Provenance is now fully supported when publishing with lerna as of v6.6.2

All of these methods (from https://docs.npmjs.com/generating-provenance-statements#using-third-party-package-publishing-tools) of letting lerna know about provenance are supported, so choose the one that works best for you:

image

Here is a real example published with lerna:

image

NOTE: Provenance is currently only supported by npm for Github Actions

How Has This Been Tested?

Types of changes

  • Chore (change that has absolutely no effect on users)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #600 (11a5ceb) into main (b043c78) will decrease coverage by 0.09%.
The diff coverage is 59.26%.

@@            Coverage Diff             @@
##             main     #600      +/-   ##
==========================================
- Coverage   98.18%   98.09%   -0.09%     
==========================================
  Files         152      152              
  Lines       11465    11491      +26     
  Branches     1880     1881       +1     
==========================================
+ Hits        11256    11271      +15     
- Misses        208      219      +11     
  Partials        1        1              
Impacted Files Coverage Δ
packages/publish/src/publish-command.ts 98.25% <59.26%> (-1.05%) ⬇️

@ghiscoding ghiscoding merged commit 51e85ea into main May 5, 2023
5 of 6 checks passed
@ghiscoding ghiscoding deleted the feat/npm-provenance branch May 5, 2023 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant