fix: CJS fallbacks should be at the end not at beginning #675
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
better hybrid CJS/ESM support
Motivation and Context
when defining the old CJS
main
andmodule
, these properties should come afterexports
(new ESM prop) so that newer NodeJS will tryexports
first (we shouldn't try the fallback first), while for old NodeJS it will automatically use the fallbacks sinceexports
won't work, see this TypeScript for more info (https://www.typescriptlang.org/docs/handbook/esm-node.html)How Has This Been Tested?
Types of changes
Checklist: