Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CJS fallbacks should be at the end not at beginning #675

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

ghiscoding
Copy link
Member

Description

better hybrid CJS/ESM support

Motivation and Context

when defining the old CJS main and module, these properties should come after exports (new ESM prop) so that newer NodeJS will try exports first (we shouldn't try the fallback first), while for old NodeJS it will automatically use the fallbacks since exports won't work, see this TypeScript for more info (https://www.typescriptlang.org/docs/handbook/esm-node.html)

How Has This Been Tested?

Types of changes

  • Chore (change that has absolutely no effect on users)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- when defining the old CJS `main` and `module`, these properties should come after `exports` (new ESM prop) so that newer NodeJS will try `exports` first (we shouldn't try the fallback first), while for old NodeJS it will automatically use the fallbacks since `exports` won't work, see this TypeScript for more info (https://www.typescriptlang.org/docs/handbook/esm-node.html)
@ghiscoding ghiscoding merged commit e3d7b9f into main Jul 17, 2023
4 checks passed
@ghiscoding ghiscoding deleted the bugfix/cjs-esm-hybrid branch July 17, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant