Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid output when using range tags #35

Closed
hzoo opened this issue Feb 1, 2017 · 5 comments
Closed

Invalid output when using range tags #35

hzoo opened this issue Feb 1, 2017 · 5 comments
Labels

Comments

@hzoo
Copy link
Contributor

hzoo commented Feb 1, 2017

This is from running changelog on https://github.com/lerna/lerna

lerna-changelog --tag-from v2.0.0-beta.32 --tag-to v2.0.0-beta.34

https://gist.github.com/hzoo/d9eb42b94824694b79be925f357549eb

@emmenko
Copy link
Contributor

emmenko commented Feb 2, 2017

What exactly am I looking at here? Can you point out the issues you see? Thanks 😉

@hzoo
Copy link
Contributor Author

hzoo commented Feb 2, 2017

So I think I would expect the changelog to have 3 entries?

first issue is the first entry is v2.0.0-beta.3 (2017-01-26) - missing a 2?

Also I'd think the order would be 32, 33, 34 or 34,33,32

and lastly the commits don't seem to correspond to the commits in the repo?

https://github.com/lerna/lerna/commits/master

@emmenko
Copy link
Contributor

emmenko commented Feb 2, 2017

I'll have a look into it as soon as I have some time.

@Turbo87 Turbo87 added the bug label Mar 3, 2017
@emmenko emmenko changed the title Weird issues? Invalid output when using range tags Mar 14, 2017
@hzoo
Copy link
Contributor Author

hzoo commented May 22, 2017

Run

git clone git@github.com:babel/babylon.git
lerna-changelog --tag-from=v7.0.0-beta.9 --tag-to=v7.0.0-beta.10
## v7.0.0-beta.1 (2017-05-22)

#### :bug: Bug Fix
* Other
  * [#478](https://github.com/babel/babylon/pull/478) Fixed disappearing comments following a trailing comma. ([@aardito2](https://github.com/aardito2))

#### Committers: 1
- [aardito2](https://github.com/aardito2)


## v7.0.0-beta.10 (2017-05-22)

#### :bug: Bug Fix
* Other
  * [#478](https://github.com/babel/babylon/pull/478) Fixed disappearing comments following a trailing comma. ([@aardito2](https://github.com/aardito2))

#### Committers: 1
- [aardito2](https://github.com/aardito2)

@Turbo87
Copy link
Contributor

Turbo87 commented May 29, 2017

@hzoo the problem is that we are using indexOf() to figure out what tag a commit belongs too and v7.0.0-beta.1 is obviously matching v7.0.0-beta.10 too 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants