fix(list): Restore empty --json array output when no results

Fixes #1945
lerna · Feb 26, 2019 · 2c925bd · 2c925bd
1 parent 93ac976
commit 2c925bd
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/commands/list/__tests__/list-command.test.js b/commands/list/__tests__/list-command.test.js
@@ -233,6 +233,15 @@ package-2
         },
       ]);
     });
+
+    it("emits empty array with no results", async () => {
+      const testDir = await initFixture("basic");
+
+      collectUpdates.setUpdated(testDir);
+      await lernaLs(testDir)("--since", "deadbeef", "--json");
+
+      expect(JSON.parse(output.logged())).toEqual([]);
+    });
   });
 
   describe("in a Yarn workspace", () => {

diff --git a/commands/list/index.js b/commands/list/index.js
@@ -29,7 +29,7 @@ class ListCommand extends Command {
 
   execute() {
     // piping to `wc -l` should not yield 1 when no packages matched
-    if (this.result.count) {
+    if (this.result.text.length) {
       output(this.result.text);
     }