fix(add): Avoid passing bad scope to pacote

Fixes #1592
lerna · Aug 21, 2018 · ad649bf · ad649bf
1 parent 6abc0c9
commit ad649bf
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/commands/add/__tests__/add-command.test.js b/commands/add/__tests__/add-command.test.js
@@ -205,7 +205,7 @@ describe("AddCommand", () => {
   it("should only bootstrap scoped packages", async () => {
     const testDir = await initFixture("basic");
 
-    await lernaAdd(testDir)("@test/package-1", "--scope", "@test/package-2", "--scope", "package-3");
+    await lernaAdd(testDir)("tiny-tarball", "--scope", "@test/package-2", "--scope", "package-3");
 
     expect(bootstrap).lastCalledWith(
       expect.objectContaining({

diff --git a/commands/add/index.js b/commands/add/index.js
@@ -156,7 +156,11 @@ class AddCommand extends Command {
     }
 
     // @see https://github.com/zkat/pacote/blob/latest/lib/util/opt-check.js
-    const opts = npmConf(this.options);
+    const opts = npmConf({
+      includeDeprecated: false,
+      // we can't pass everything, as our --scope conflicts with pacote's --scope
+      registry: this.options.registry,
+    });
 
     return pacote.manifest(this.spec, opts).then(pkg => pkg.version);
   }