fix(version): Throw errors if tree is unclean or duplicating tagged r…

…elease
lerna · Aug 17, 2018 · d8ee1cf · d8ee1cf
1 parent 5da0e42
commit d8ee1cf
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/commands/version/index.js b/commands/version/index.js
@@ -11,6 +11,7 @@ const semver = require("semver");
 
 const Command = require("@lerna/command");
 const ConventionalCommitUtilities = require("@lerna/conventional-commits");
+const checkWorkingTree = require("@lerna/check-working-tree");
 const PromptUtilities = require("@lerna/prompt");
 const output = require("@lerna/output");
 const collectUpdates = require("@lerna/collect-updates");
@@ -144,6 +145,11 @@ class VersionCommand extends Command {
       () => this.confirmVersions(),
     ];
 
+    // amending a commit probably means the working tree is dirty
+    if (amend !== true) {
+      tasks.unshift(() => checkWorkingTree(this.execOpts));
+    }
+
     return pWaterfall(tasks);
   }
 

diff --git a/commands/version/package.json b/commands/version/package.json
@@ -32,6 +32,7 @@
     "test": "echo \"Run tests from root\" && exit 1"
   },
   "dependencies": {
+    "@lerna/check-working-tree": "file:../../utils/check-working-tree",
     "@lerna/child-process": "file:../../core/child-process",
     "@lerna/collect-updates": "file:../../utils/collect-updates",
     "@lerna/command": "file:../../core/command",

diff --git a/package-lock.json b/package-lock.json