Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignored "nohoist" in lerna.json #1337

Closed
koshic opened this issue Mar 19, 2018 · 5 comments
Closed

Ignored "nohoist" in lerna.json #1337

koshic opened this issue Mar 19, 2018 · 5 comments

Comments

@koshic
Copy link

koshic commented Mar 19, 2018

Expected Behavior

Lerna should respect "nohoist" option in config

Current Behavior

3.0.0-beta.4 ignores this option

Possible Solution

Looks like a bug - concat nohoist to hoisting array, it should be something like filter:

  if (nohoist) {
    // `--nohoist ...` or lerna.json `nohoist: [...]`
    hoisting = hoisting.concat(nohoist);
  }
@evocateur
Copy link
Member

What config is triggering this? Does the github issue template no longer include <!-- Please paste your lerna.json here -->?

@evocateur
Copy link
Member

Nevermind, I got a repro. The test snapshot isn't exactly clear. :/

@koshic
Copy link
Author

koshic commented Mar 19, 2018

I'm sorry for confusing - I thought that buggy code snippet from https://github.com/lerna/lerna/blob/master/commands/bootstrap/index.js makes it clear. So, do you need any additional info?

@evocateur
Copy link
Member

Nope, just dealing with publish issues because I forgot a flag 😭

@lock
Copy link

lock bot commented Dec 27, 2018

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants