Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lerna 3.0.0-rc.0 to 3.0.0 caused breaking changes with split of lerna version from publish #1553

Closed
kirbdee opened this issue Aug 10, 2018 · 6 comments

Comments

@kirbdee
Copy link

kirbdee commented Aug 10, 2018

Expected Behavior

lerna publish to accept version flags prior to handle version bumping publishing

Current Behavior

have to explicitly call lerna version prior

Possible Solution

This should have been considered a breaking change.

Steps to Reproduce (for bugs)

lerna publish --skip-npm --conventional-commits --yes
Conventional was no longer being used

lerna.json

<!-- Please paste your `lerna.json` here -->

lerna-debug.log

<!-- If you have a `lerna-debug.log` available, please paste it here -->
<!-- Otherwise, feel free to delete this <details> block -->

Context

Your Environment

Executable Version
lerna --version VERSION
npm --version VERSION
yarn --version VERSION
node --version VERSION
OS Version
NAME VERSION
@kirbdee kirbdee changed the title Lerna 3.0.0-rc.0 to v3.0.0 caused breaking changes with split of lerna version from publish Lerna 3.0.0-rc.0 to 3.0.0 caused breaking changes with split of lerna version from publish Aug 10, 2018
@evocateur
Copy link
Member

lerna version --conventional-commits --yes should work fine, is the error message not clear enough?

@kirbdee
Copy link
Author

kirbdee commented Aug 10, 2018

No that makes sense, I didn't notice it until I saw my CICD do something unexpected.

@evocateur
Copy link
Member

That being said, we have integration tests that validate passing --conventional-commits to lerna publish passes it through successfully. I'll need a reproduction of your case to verify if it's an actual bug.

@kirbdee
Copy link
Author

kirbdee commented Aug 10, 2018

No worries, I've moved to 3.0.1 from the 3.0.0-rc.0 with the appropriate changes.

@evocateur
Copy link
Member

I just realized I forgot to add a hidden --skip-npm yargs option to lerna publish, so this would indeed fail despite the internal aliasing already in place. Silly unit tests lying to me...

@evocateur evocateur reopened this Aug 11, 2018
@lock
Copy link

lock bot commented Dec 27, 2018

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants