-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update conventional changelog deps #1661
Conversation
tagging @hbetts as he was the one he released the changes to convetional-changelog to confirm that these changes are safe. |
The first package has changes in behavior that may effect Lerna users. Mostly it may change how commit messages are interpreted because of the changes to the |
2592523
to
024c0df
Compare
@hbetts i removed my change for angular and only bumped recommended by 1 major since that major was only the node change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your lockfile changes are too broad, you appear to be using an old version of npm 5? It should not be removing the version ranges in the requires
blocks. npm v5.10.0 or npm v6+ will properly update the lockfile.
@hbetts Thanks for the clarification! |
I am using npm 5.5 it seems i'll update to latest npm and rebase this PR |
This bumps the version to the latest major. The biggest change was that it requires Node 6+ and since Lerna already requries that this bump should not affect consumers. fixes lerna#1641
024c0df
to
d065a29
Compare
@evocateur I updated the package-lock with npm 6+. Is it good now? |
This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
This bumps the version to the latest major. The biggest change
was that it requires Node 6+ and since Lerna already requries
that this bump should not affect consumers.
Motivation and Context
See issue #1641
How Has This Been Tested?
I tried running npm run test locally, but start getting jest timeouts. Is there something I can do to get that fully test. I assume the PR will trigger some CI to test so many it's not needed?
Types of changes
Checklist: