Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update conventional changelog deps #1661

Closed

Conversation

mlavina
Copy link
Contributor

@mlavina mlavina commented Sep 6, 2018

Description

This bumps the version to the latest major. The biggest change
was that it requires Node 6+ and since Lerna already requries
that this bump should not affect consumers.

Motivation and Context

See issue #1641

How Has This Been Tested?

I tried running npm run test locally, but start getting jest timeouts. Is there something I can do to get that fully test. I assume the PR will trigger some CI to test so many it's not needed?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mlavina
Copy link
Contributor Author

mlavina commented Sep 6, 2018

tagging @hbetts as he was the one he released the changes to convetional-changelog to confirm that these changes are safe.

@hutson
Copy link

hutson commented Sep 6, 2018

The first package has changes in behavior that may effect Lerna users. Mostly it may change how commit messages are interpreted because of the changes to the angular convention, which is the default Lerna.

@mlavina mlavina force-pushed the fix/deps/updateConventionalChangelog branch from 2592523 to 024c0df Compare September 10, 2018 13:52
@mlavina
Copy link
Contributor Author

mlavina commented Sep 10, 2018

@hbetts i removed my change for angular and only bumped recommended by 1 major since that major was only the node change

Copy link
Member

@evocateur evocateur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your lockfile changes are too broad, you appear to be using an old version of npm 5? It should not be removing the version ranges in the requires blocks. npm v5.10.0 or npm v6+ will properly update the lockfile.

@evocateur
Copy link
Member

@hbetts Thanks for the clarification!

@mlavina
Copy link
Contributor Author

mlavina commented Sep 11, 2018

I am using npm 5.5 it seems i'll update to latest npm and rebase this PR

This bumps the version to the latest major. The biggest change
was that it requires Node 6+ and since Lerna already requries
that this bump should not affect consumers.

fixes lerna#1641
@mlavina mlavina force-pushed the fix/deps/updateConventionalChangelog branch from 024c0df to d065a29 Compare September 19, 2018 21:13
@mlavina
Copy link
Contributor Author

mlavina commented Sep 19, 2018

@evocateur I updated the package-lock with npm 6+. Is it good now?

@lock
Copy link

lock bot commented Dec 27, 2018

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants