New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong changelog/release commit links #2299
Comments
Hi Folks 👋 You may or may not know that lerna is now under the stewardship of Nrwl (announcement here #3121), a company with a long history of not just producing valuable open-source software (OSS), but also backing others (at the time of writing, Nrwl has donated over $50,000 to OSS it hasn't created, see https://opencollective.com/nx for full details). Quite simply, Nrwl ❤️ OSS, and is committed to making lerna the best it can be. We use it ourselves. In order to take this awesome project forward from its current state, it is important that we focus our finite resources on what is most important to lerna users in 2022. With that in mind, we have identified this issue as being potentially stale due to its age and/or lack of recent activity. Next steps: We want to give you some time to read through this comment and take action per one of the steps outlined below, so for the next 14 days we will not make any further updates to this issue. @tunnckoCore as the original author of this issue, we are looking to you to update us on the latest state of this as it relates to the latest version of lerna. Please choose one of the steps below, depending on what type of issue this is:
If we do not hear from @tunnckoCore on this thread within the next 14 days, we will automatically close this issue. If you are another user impacted by this issue but it ends up being closed as part of this process, we still want to hear from you! Please simply head over to our new issue templates and fill out all the requested details on the template which applies to your situation: https://github.com/lerna/lerna/issues/new/choose Thank you all for being a part of this awesome community, we could not be more excited to help move things forward from here 🙏 🚀 |
Yep. Of course. Worth no time. I can handle it when I come back. |
If you have monorepo and you have set the
repository
field to be a link to the package, e.g.https://github.com/user/repo/packages/foobar
, then it will produce broken links in the release notes and the changelogs, appending/commit/2ac345
for example.The reason why some of us using
repository
field that way is most probably because it is shown on the npmjs.com package page - that's also the reason I'm not usingrepository.directory
. For me, one more reason, I'm using http://ghub.io and have a browser search engine for it, e.g.gn package-name
goes directly to the package's repository. Suggested a fix/support there nice-registry/ghub.io#279.Expected Behavior
Produce correct links to commits
Current Behavior
Broken commit links.
Possible Solution
The problem doesn't come exactly from Lerna, but most probably from https://github.com/conventional-changelog/get-pkg-repo which is used under the hood. And I'm not sure if it can be fixed here, otherwise the mentioned package shoudl add "support" for this. Something like
Your Environment
lerna --version
npm --version
yarn --version
node --version
The text was updated successfully, but these errors were encountered: