-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build-metadata to lerna version / publish #2545
Add build-metadata to lerna version / publish #2545
Comments
Hey @jonathanmorley, not sure if anyone else is working on this, but I'm looking into it in my own time to see if I can implement a solution. Hopefully have something to present in the coming week or two depending how complex this proves to be, will share an update if I have any success. |
Quick update from me: I think I have all the code changes required to support this, just need to verify the logic with some integration tests. Hope to have something open for review either this week or early next. |
@rrhodes hey good work on the PR! Can you help to publish it temporarily (with fork disclaimer perhaps) so that I could have a way to test it as well? |
Hello @josteph, if you would like to test my changes for Lerna, you should be able to run this from your machine if you pull down my branch of work. Hoping to have these changes reviewed soon - waiting to hear from Lerna maintainers. |
Any updates on this issue? PR? |
PR linked above. Although I think Lerna is no longer maintained, unless I'm mistaken? So I suspect this may not be merged into |
Ahh, missed that 👍
It is maintained #3121 |
Ah, that's great news! Thanks for the head's up. In which case, @jeffbcross and team may be able to help here, not sure how this may fit into any considered roadmaps? |
So sorry for the delay on this one folks, let's get @rrhodes PR over the line! |
The semver standard provides for a 'build-metadata' section in the version number, which is separated from the pre-release identifers by a plus-sign (+).
The examples given are
+001
,+20130313144700
,+exp.sha.5114f85
.I would like to see an argument to lerna version and publish that would apply this build metadata consistently across all packages in the repo (irrespective of independent vs fixed versioning)
This is not currently workaroundable with something like
--preid=foo+bar
, because:1.0.0-foo+bar.0
, rather than1.0.0-foo.0+bar
The text was updated successfully, but these errors were encountered: