Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build-metadata to lerna version / publish #2545

Closed
jonathanmorley opened this issue Apr 16, 2020 · 9 comments · Fixed by #2880 or lerna-lite/lerna-lite#504
Closed

Add build-metadata to lerna version / publish #2545

jonathanmorley opened this issue Apr 16, 2020 · 9 comments · Fixed by #2880 or lerna-lite/lerna-lite#504

Comments

@jonathanmorley
Copy link

The semver standard provides for a 'build-metadata' section in the version number, which is separated from the pre-release identifers by a plus-sign (+).

The examples given are +001, +20130313144700, +exp.sha.5114f85.

I would like to see an argument to lerna version and publish that would apply this build metadata consistently across all packages in the repo (irrespective of independent vs fixed versioning)

This is not currently workaroundable with something like --preid=foo+bar, because:

  1. This would create a version number like 1.0.0-foo+bar.0, rather than 1.0.0-foo.0+bar
  2. build-metadata is valid to append to release versions (not just pre-releases)
@rrhodes
Copy link
Contributor

rrhodes commented Apr 7, 2021

Hey @jonathanmorley, not sure if anyone else is working on this, but I'm looking into it in my own time to see if I can implement a solution. Hopefully have something to present in the coming week or two depending how complex this proves to be, will share an update if I have any success.

@rrhodes
Copy link
Contributor

rrhodes commented Apr 18, 2021

Quick update from me: I think I have all the code changes required to support this, just need to verify the logic with some integration tests. Hope to have something open for review either this week or early next.

@josteph
Copy link

josteph commented Jun 25, 2021

@rrhodes hey good work on the PR!

Can you help to publish it temporarily (with fork disclaimer perhaps) so that I could have a way to test it as well?

@rrhodes
Copy link
Contributor

rrhodes commented Jun 27, 2021

@rrhodes hey good work on the PR!

Can you help to publish it temporarily (with fork disclaimer perhaps) so that I could have a way to test it as well?

Hello @josteph, if you would like to test my changes for Lerna, you should be able to run this from your machine if you pull down my branch of work.

Hoping to have these changes reviewed soon - waiting to hear from Lerna maintainers.

@erictuvesson
Copy link

Any updates on this issue? PR?

@rrhodes
Copy link
Contributor

rrhodes commented Aug 17, 2022

PR linked above. Although I think Lerna is no longer maintained, unless I'm mistaken? So I suspect this may not be merged into master within this repository.

@erictuvesson
Copy link

Ahh, missed that 👍

Although I think Lerna is no longer maintained, unless I'm mistaken? So I suspect this may not be merged into master within this repository.

It is maintained #3121

@rrhodes
Copy link
Contributor

rrhodes commented Aug 17, 2022

Ahh, missed that 👍

Although I think Lerna is no longer maintained, unless I'm mistaken? So I suspect this may not be merged into master within this repository.

It is maintained #3121

Ah, that's great news! Thanks for the head's up. In which case, @jeffbcross and team may be able to help here, not sure how this may fit into any considered roadmaps?

@JamesHenry
Copy link
Member

So sorry for the delay on this one folks, let's get @rrhodes PR over the line!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants