Should changed packages include cross-depencies?

[jamiebuilds]

Right now when publishing a new version we:

1. Find all the changed packages by checking their diffs. ref
2. Cross check these "changed packages" for cross-deps and update them in package.json. ref
3. However, we don't update cross-dependencies outside of the original changed packages. (ref1, ref2)

I feel like this will cause issues with major versions. Because we're relying on npm's ^x.x.x version matching for minor and patch versions outside of the changed packages.

[hzoo]

Yeah I think you're right on that.
Could we do that only if it's a major version change? Thats kinda what FORCE_VERSION does (but it would update all packages).

[jamiebuilds]

Only doing it on major versions sounds like the best solution. The question is if we recursively look up changed packages or bump them all.

I'm concerned about how this would interact with #20

[jamiebuilds]

Fixed in 2.0.0-beta.4

[lock]

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.