Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace ranges are not resolved for devDependencies and peerDependencies #3619

Open
snebjorn opened this issue Mar 25, 2023 · 0 comments
Open

Comments

@snebjorn
Copy link

Current Behavior

Currently workspace ranges (workspace:~|^|*) are only resolved for dependencies and optionalDependencies.

Relevant code:

resolveWorkspaceDependencyLinks() {

Expected Behavior

Workspace ranges (workspace:~|^|*) should also be resolved for devDependencies and peerDependencies.

Steps to Reproduce

I updated your example repo to use workspace ranges.
https://github.com/snebjorn/getting-started-example/tree/workspace

When remixapp is published it'll have

  "devDependencies": {
    "footer": "workspace:*",
    "header": "workspace:*"
  },
  "peerDependencies": {
    "footer": "workspace:*",
    "header": "workspace:*"
  },

yarn pack handles this correctly.

Failure Logs / Configuration

No error log

{
  "$schema": "node_modules/lerna/schemas/lerna-schema.json",
  "version": "0.0.0",
  "useWorkspaces": true,
  "npmClient": "yarn",
  "loglevel": "debug",
  "registry": "http://localhost:4873"
}

Environment

$ yarn lerna info
lerna sill argv {
lerna sill argv _: [ 'info' ],
lerna sill argv lernaVersion: '6.6.0',
lerna sill argv '$0': 'node_modules\lerna\dist\cli.js'
lerna sill argv }
lerna notice cli v6.6.0
lerna verb rootPath ~\Repos\getting-started-example

Environment info:

System:
OS: Windows 10 10.0.19045
CPU: (8) x64 Intel(R) Core(TM) i7-4790K CPU @ 4.00GHz
Binaries:
Node: 18.13.0 - ~\AppData\Local\Temp\xfs-56bd3820\node.CMD
Yarn: 3.5.0 - ~\AppData\Local\Temp\xfs-56bd3820\yarn.CMD
npm: 9.5.1 - C:\Program Files\nodejs\npm.CMD
Utilities:
Git: 2.37.3.
npmPackages:
lerna: ^6.0.1 => 6.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant