Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publish): use correct version in log messages #3702

Merged
merged 2 commits into from
Jun 1, 2023

Conversation

fahslaj
Copy link
Contributor

@fahslaj fahslaj commented May 31, 2023

Description

Uses the correct key when looking up versions for confirmation.

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nx-cloud
Copy link

nx-cloud bot commented May 31, 2023

☁️ Nx Cloud Report

Attention: This version of the Nx Cloud GitHub bot will cease to function on July 1st, 2023. An organization admin can update your integration here.

CI is running/has finished running commands for commit 688d05c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 9 targets

Sent with 💌 from NxCloud.

@fahslaj fahslaj marked this pull request as ready for review May 31, 2023 15:33
@fahslaj fahslaj requested a review from JamesHenry May 31, 2023 15:33
@@ -550,10 +550,12 @@ class PublishCommand extends Command {
}

private confirmPublish() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the bulk of the PR's changes. The changelog file changes are due to npx nx format:check failing on the v7 branch.

@fahslaj fahslaj merged commit 4be9188 into lerna:v7 Jun 1, 2023
12 checks passed
@fahslaj fahslaj deleted the fix/publish-confirmation-messages branch June 1, 2023 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant