Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publish): catch publish conflict 403 error from npm #3753

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

fahslaj
Copy link
Contributor

@fahslaj fahslaj commented Jun 26, 2023

Description

Catches another possible form of publish conflict error from npm.

Motivation and Context

Some permission setups on npm were causing a 403 error instead of the EPUBLISHCONFLICT code, and this ensures they are caught appropriately.

How Has This Been Tested?

This has been tested manually by publishing packages to npm with conflicts, observing the error in Lerna, then testing it again with this change and observing Lerna properly swallow the error.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@fahslaj fahslaj marked this pull request as ready for review June 26, 2023 22:15
@fahslaj fahslaj requested a review from JamesHenry June 26, 2023 22:15
@JamesHenry JamesHenry merged commit 6123e86 into lerna:main Jun 27, 2023
13 checks passed
@JamesHenry JamesHenry deleted the fix/publish-retry-v7 branch June 27, 2023 11:52
@matheo
Copy link
Contributor

matheo commented Jun 28, 2023

@fahslaj a simple question please:
when will this be released? I imagine the releases comes as new stuff is done right? or is there any cadence?

@JamesHenry
Copy link
Member

@matheo it's available in 7.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants