Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump nx to >=16.5.1 #3767

Merged
merged 4 commits into from
Jul 14, 2023
Merged

Conversation

fahslaj
Copy link
Contributor

@fahslaj fahslaj commented Jul 10, 2023

Description

Updates Lerna to expect Nx >=16.5.1 and uses new src imports for nx utilities. Also sorts the dependencies from the Nx project graph in order to process cycles in a deterministic way.

Motivation and Context

This keeps Lerna fresh with the latest changes of Nx and ensures future compatibility.

How Has This Been Tested?

This was tested manually, and all existing tests pass.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@fahslaj fahslaj marked this pull request as ready for review July 10, 2023 22:02
@fahslaj fahslaj requested a review from JamesHenry July 10, 2023 22:05
@JamesHenry
Copy link
Member

@fahslaj FYI this isn't a chore, it changes the dependencies of the lerna package, so it's a fix at minimum

@JamesHenry JamesHenry changed the title chore: bump nx to >=16.5.1 fix: bump nx to >=16.5.1 Jul 14, 2023
@JamesHenry JamesHenry merged commit 0bbd74d into lerna:main Jul 14, 2023
13 checks passed
@JamesHenry JamesHenry deleted the chore/bump-nx-version branch July 14, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants