Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(version): remove explicit node_modules require #3804

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

fahslaj
Copy link
Contributor

@fahslaj fahslaj commented Aug 9, 2023

Description

Removes the explicit require on a node_modules path for prettier.

Motivation and Context

This allows the required prettier to follow the normal node rules for importing modules, which also allows it to support Yarn PnP.

How Has This Been Tested?

This has been tested manually. All automated tests pass.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@fahslaj fahslaj marked this pull request as ready for review August 10, 2023 14:29
@fahslaj fahslaj merged commit 1a113f7 into lerna:main Aug 11, 2023
13 checks passed
@fahslaj fahslaj deleted the fix/require-generic-prettier branch August 11, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants