-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(init): detect existing package manager and auto-install packages #3805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fahslaj
changed the title
feat(init): detect existing package manager
feat(init): detect existing package manager and auto-install packages
Aug 11, 2023
fahslaj
force-pushed
the
feat/detect-package-manager
branch
2 times, most recently
from
August 14, 2023 16:08
0b20e2a
to
48b6216
Compare
fahslaj
force-pushed
the
feat/detect-package-manager
branch
from
August 14, 2023 16:11
48b6216
to
93ffa64
Compare
fahslaj
force-pushed
the
feat/detect-package-manager
branch
from
August 14, 2023 16:55
cadb7f2
to
9be57e7
Compare
JamesHenry
reviewed
Aug 14, 2023
JamesHenry
requested changes
Aug 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the one nit, please could update the docs to make note of this new behaviour?
JamesHenry
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Detects the package manager during
lerna init
by looking for existing lockfiles. Also makes theinit
command perform an installation task after the initialization to ensure Lerna is downloaded from the registry.Motivation and Context
This makes it easier to add Lerna to a project that is managed by Yarn or Pnpm.
How Has This Been Tested?
This has been tested manually and covered by e2e tests.
Types of changes
Checklist: