-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Option instead of lastTag/lastRelease for updated packages #89
Comments
If you are in a separate branch for the older version I assume we can just change: - git rev-list --tags --max-count=1 # get commit of last tag across branches
+ git rev-list -n 1 $(git describe --tags) # get commit of last tag in current branch [ref] |
Would you ever want to do anything else such that you might want to specify the version manually? Probably not right? What do you think about logging that info in the lerna updated/publish command as well? Basically something like And based on your suggestion, we just check the current branch - if it's |
Bump, We got into this issue, that if we do changes on different branches for different versions, we need to use newest tag in that branch, not in whole project. Could we try to do a pull request for this feature? Maybe add passing some kind of parameter for turning this option on? Edit: Fixed typo (dumb -> bump, I seriously didn't mean to write that). |
This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Right now we figure out what packages to publish based on a git diff of the lastTag.
However in the case of a backport (you might publish v5.x.x after a v.6.x.x) and now the lastTag is actually v5.x.x, so maybe you should be able to pass in a tag, otherwise default to the latest (we should log out the last tag if we aren't already or prompt it).
The text was updated successfully, but these errors were encountered: