Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small Bug in SimpleCamera2Activity #216

Closed
infologika-outsrc opened this issue Feb 17, 2021 · 2 comments
Closed

Small Bug in SimpleCamera2Activity #216

infologika-outsrc opened this issue Feb 17, 2021 · 2 comments
Assignees

Comments

@infologika-outsrc
Copy link

Thank you very much for the library.
There is a small bug in SimpleCamera2Activity.java

In routine
public void cameraIntrinsicNominal(CameraPinhole intrinsic )

The code:
// 60 degrees seems reasonable for a random guess
PerspectiveOps.createIntrinsic(open.mCameraSize.getWidth(),open.mCameraSize.getHeight(),
UtilAngle.radian(60));

Should be enclosed inside the

if (open.mCameraCharacterstics != null) {
}

block, and not after it.

Otherwise it crashes occasionally.

@lessthanoptimal
Copy link
Owner

Yep that looks like a bug. It's in the queue to get fixed. Thanks!

@lessthanoptimal
Copy link
Owner

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants