Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced Row Echelon Form Bug #115

Closed
KayakDov opened this issue Dec 20, 2020 · 2 comments
Closed

Reduced Row Echelon Form Bug #115

KayakDov opened this issue Dec 20, 2020 · 2 comments
Assignees
Labels
bug fixed Fixed. Waiting review. verified Bug/Problem has been verified

Comments

@KayakDov
Copy link

The following code does not yield reduced row echelon form.

DMatrixRMaj matrix = new DMatrixRMaj(2, 3, true, new double[]{0,2,2,0,0,2});
System.out.println(CommonOps_DDRM.rref(matrix, -1, null));

Prints:
Type = DDRM , rows = 2 , cols = 3
0.0000E+00 1.0000E+00 1.0000E+00
0.0000E+00 0.0000E+00 2.0000E+00

but the first non zero element on each row should be 1.

@lessthanoptimal
Copy link
Owner

Deleted first reply since I can't apparently read. Looking into this.

@lessthanoptimal
Copy link
Owner

Fixed the issue. Combination of bad test coverage of bad default value for number of columns. Thanks for pointing out the problem. I'm surprised this went unnoticed for so long!

#130

Also apologies for taking so long to look into this and missing it in the last release.

@lessthanoptimal lessthanoptimal self-assigned this Feb 11, 2021
@lessthanoptimal lessthanoptimal added bug fixed Fixed. Waiting review. verified Bug/Problem has been verified labels Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fixed Fixed. Waiting review. verified Bug/Problem has been verified
Projects
None yet
Development

No branches or pull requests

2 participants