Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #20, it would be really practical to have these optimizers in a package. This PR makes that possible.
ranger
can be installed and imported in all python projects, no need to copy paste the ranger optimizer anymore. This also allows to give you proper credit where it is used (I'll add it in the requirements inasteroid
for example).I also updated the README with the install and usage instruction.
You can clone the repo, then install it with
pip
in editable mode (pretty practical for research) or not.Note : In the
__init__.py
I imported the three optimizers so that they can be imported from the package directly (from ranger import RangerQH
instead offrom ranger.rangerqh import RangerQH
). Bothranger.py
andranger913A.py
had the same name for the class, so I changed the class inranger913A.py
toRangerVA
(for versionA).I'd like to here from you, this would be very practical to have it as a package.