Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N_sma_threshhold should be instance variable #7

Closed
ohmorimori opened this issue Aug 31, 2019 · 2 comments
Closed

N_sma_threshhold should be instance variable #7

ohmorimori opened this issue Aug 31, 2019 · 2 comments

Comments

@ohmorimori
Copy link

Thank you for the great implementation.
I think I found a small part to modify at ranger.py line 116.

original code:
if N_sma > N_sma_threshhold:

to be left:
if N_sma > self.N_sma_threshhold:

@lessw2020
Copy link
Owner

Hi @ohmorimori - you are correct, ,thanks for pointing this out.
That is my mistake for not running the code, I just fixed in here directly b/c it was "so simple".
I'm running the correction now and will check it in.

@lessw2020
Copy link
Owner

Fixed - thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants