Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean and harmonize jws/main.go/headers.go #122

Closed
BenderScript opened this issue Apr 28, 2019 · 4 comments
Closed

Clean and harmonize jws/main.go/headers.go #122

BenderScript opened this issue Apr 28, 2019 · 4 comments

Comments

@BenderScript
Copy link
Contributor

Remove package name from const names
Use "name" instead of "method". We do not use "method" per se anymore after all changes, i.e., there is no direct call to any method.
Use GetAlgorithm() instead of Algorithm()
Added PrivateParams as a JSON tag. But if we want flattened we can change asap.

I am trying to get all generate code to look similar and follow a pattern.

@lestrrat
Copy link
Collaborator

no, please dont rename method names.

@BenderScript
Copy link
Contributor Author

BenderScript commented Apr 28, 2019

please check the code and ask for any changes you want. I will be happy to change.

@lestrrat
Copy link
Collaborator

i hope you don't take this the wrong way but i should tell you that while your involvement has been greatly appreciated, in general if you want sweeping style/api changes you should consider forking instead of making prs.

there is no way short of a complete messup on my part that I will merge style/api changes that doesn't fix a real problem.

@BenderScript
Copy link
Contributor Author

Of course I will not take it the wrong way. No problem. I will make the changes only on my copy of the repo. I will close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants