-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean and harmonize jws/main.go/headers.go #122
Comments
no, please dont rename method names. |
please check the code and ask for any changes you want. I will be happy to change. |
i hope you don't take this the wrong way but i should tell you that while your involvement has been greatly appreciated, in general if you want sweeping style/api changes you should consider forking instead of making prs. there is no way short of a complete messup on my part that I will merge style/api changes that doesn't fix a real problem. |
Of course I will not take it the wrong way. No problem. I will make the changes only on my copy of the repo. I will close this PR. |
Remove package name from const names
Use "name" instead of "method". We do not use "method" per se anymore after all changes, i.e., there is no direct call to any method.
Use GetAlgorithm() instead of Algorithm()
Added PrivateParams as a JSON tag. But if we want flattened we can change asap.
I am trying to get all generate code to look similar and follow a pattern.
The text was updated successfully, but these errors were encountered: