Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low coverage and unused functions in jwk/headers_gen.go #92

Closed
BenderScript opened this issue Apr 8, 2019 · 0 comments · Fixed by #95
Closed

Low coverage and unused functions in jwk/headers_gen.go #92

BenderScript opened this issue Apr 8, 2019 · 0 comments · Fixed by #95

Comments

@BenderScript
Copy link
Contributor

These functions are not used or covered

jwx/jwk/headers_gen.go

Lines 98 to 117 in 9871a56

func (h *StandardHeaders) X509CertThumbprint() string {
if v := h.x509CertThumbprint; v != nil {
return *v
}
return ""
}
func (h *StandardHeaders) X509CertThumbprintS256() string {
if v := h.x509CertThumbprintS256; v != nil {
return *v
}
return ""
}
func (h *StandardHeaders) X509URL() string {
if v := h.x509URL; v != nil {
return *v
}
return ""
}

These functions are not used:

func (h StandardHeaders) MarshalJSON() ([]byte, error) {

func (h *StandardHeaders) UnmarshalJSON(buf []byte) error {

These lines are not covered

jwx/jwk/headers_gen.go

Lines 345 to 362 in 9871a56

if v, ok := m[X509CertThumbprintKey]; ok {
if err := h.Set(X509CertThumbprintKey, v); err != nil {
return errors.Wrapf(err, `failed to set value for key %s`, X509CertThumbprintKey)
}
delete(m, X509CertThumbprintKey)
}
if v, ok := m[X509CertThumbprintS256Key]; ok {
if err := h.Set(X509CertThumbprintS256Key, v); err != nil {
return errors.Wrapf(err, `failed to set value for key %s`, X509CertThumbprintS256Key)
}
delete(m, X509CertThumbprintS256Key)
}
if v, ok := m[X509URLKey]; ok {
if err := h.Set(X509URLKey, v); err != nil {
return errors.Wrapf(err, `failed to set value for key %s`, X509URLKey)
}
delete(m, X509URLKey)
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant