Negative Seconds with fractional seconds had the wrong sign #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lestrrat
added a commit
that referenced
this pull request
Mar 15, 2021
Changelog diff is:
diff --git a/Changes b/Changes
index ff0d37d..ac8a229 100644
--- a/Changes
+++ b/Changes
@@ -1,6 +1,8 @@
Revision history for Perl extension DateTime::Format::Pg.
{{$NEXT}}
+
+0.16014 2021-03-15T13:40:40Z
- Fix handling for fractional seconds (#17)
- Accept concatenated dates (#18)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an negative interval if, the seconds part has a fractional part. The existing code will consider the seconds to be positive - causing the result to be up to about 2 minutes out, the added test without the fix gives
prove.txt