parse_interval support for full syntax #7
Conversation
|
The fact that pre-existing tests needed to be changed kind of bugs me. Does this mean it's going to break existing behavior? |
|
From what I can see the modified test line was actually buggy (1 day 1 month certainly doesn't mean -1 day), and the commented-out negative data are certainly supported forms by Postgres (9.3 in my case anyway). If anyone built upon the wrong assumption that '1 day 1 month' has negative day, not sure how to act, their program is probably already broken, and a bug has been fixed. Certainly changes existing behaviour, but that behaviour was bad. Looks like a nice patch though :) @nbezzala Does your patch make the module support secondless time forms? Pg seems to be fine with |
|
Anything up with this one? :) |
parse_interval support for full syntax
Changelog diff is:
diff --git a/Changes b/Changes
index 41cc962..28fe9cc 100644
--- a/Changes
+++ b/Changes
@@ -2,6 +2,9 @@ Revision history for Perl extension DateTime::Format::Pg.
{{$NEXT}}
+0.16011 2015-06-19T13:40:27Z
+ - Support full interval syntax [pr #7]
+
0.16010 2014-09-18T12:36:03Z
- Add support for various more interval units [pr #3]:
millenium, century, decade, month, week
|
hmm, I guess I didn't notice the last email sent to me. |
Changelog diff is:
diff --git a/Changes b/Changes
index 28fe9cc..64896d0 100644
--- a/Changes
+++ b/Changes
@@ -2,6 +2,11 @@ Revision history for Perl extension DateTime::Format::Pg.
{{$NEXT}}
+0.16012 2016-07-19T21:37:31Z
+ - Parsing invalid intervals with no amount and units only should have
+ resulted in exceptions, but did not. Reported by Henrik Pauli (ssue #8)
+ - Internal cleanup
+
0.16011 2015-06-19T13:40:27Z
- Support full interval syntax [pr #7]
Solution for issue #5
Still need to add support for frc. I don't really understand what it is, how you are getting it and how that part works.