ipc:// is not supported on Windows #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://zeromq.jira.com/browse/LIBZMQ-153 - here's official bug report. I used a rather dirty way of getting a free port instead of `TCP::Test::empty_port()` as I didn't want to introduce a dependency on `TCP::Test` if it's not really needed. And I didn't want to make code much more complicated either. So now we have a clear improvement on Windows (it kind of works instead of total failure), and on Unix the code didn't change.
|
Okay, I'm willing to accept this punt :) |
lestrrat
added a commit
that referenced
this pull request
Jun 18, 2014
ipc:// is not supported on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://zeromq.jira.com/browse/LIBZMQ-153 - here's official bug report.
I used a rather dirty way of getting a free port instead of
TCP::Test::empty_port()as I didn't want to introduce a dependency onTCP::Testif it's not really needed. And I didn't want to make code much more complicated either.So now we have a clear improvement on Windows (it kind of works instead of total failure), and on Unix the code didn't change.