Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve graceful shutdown #2

Open
leszkolukasz opened this issue Jul 18, 2023 · 0 comments
Open

Improve graceful shutdown #2

leszkolukasz opened this issue Jul 18, 2023 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@leszkolukasz
Copy link
Owner

Description

Right now, graceful shutdown is not so graceful. It is possible that some threads from ThreadPool are still working but ServletContainer::start finished.

Task

Make sure so that ServletContainer::start finishes only when all servlets have stopped. That should also include asynchronous servlets that use CompletableFuture instead of ThreadPool.
@leszkolukasz leszkolukasz added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leszkolukasz